[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152903|review?                     |review-
               Flag|                            |




--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-07-17 20:03:48 PST ---
(From update of attachment 152903)
View in context: https://bugs.webkit.org/attachment.cgi?id=152903&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:80
> +    PermissionsMap::iterator iter = m_cachedPermissions.find(context->securityOrigin()->toString());
> +
> +    if (iter == m_cachedPermissions.end())
> +        return PermissionNotAllowed;
> +
> +    if (iter->second)
> +        return PermissionAllowed;
> +
>      return PermissionDenied;
>  }

So this will never reach the last return? What is the difference between Denied and NotAllowed?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:82
> +void NotificationPresenterClientEfl::addPermissionCache(const char* domain, const bool isAllowed)

addTo ?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:89
> +    PermissionsMap::iterator iter = m_cachedPermissions.find(String(domain));
> +
> +    if (iter == m_cachedPermissions.end())
> +        return;
> +
> +    m_cachedPermissions.add(String(domain), isAllowed);

So you check whehter is is already cached. If it is not you return, thus never cache :-(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.