[Webkit-unassigned] [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90880


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152787|                            |review-
               Flag|                            |




--- Comment #50 from Pavel Feldman <pfeldman at chromium.org>  2012-07-17 11:16:51 PST ---
(From update of attachment 152787)
View in context: https://bugs.webkit.org/attachment.cgi?id=152787&action=review

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:73
> +static Color parseColor(const RefPtr<InspectorObject>* colorObject)

Overlay is a utility class, it should not depend on the inspector transport objects.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:585
> +    m_highlightData = adoptPtr(new HighlightData());

I think this method should receive PassRefPtr<HighlightData> instead.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:594
> +    m_highlightData = adoptPtr(new HighlightData());

ditto

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:611
> +    highlightConfig->getBoolean("showInfo", &showInfo);

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.