[Webkit-unassigned] [Bug 19681] borderColor on table elements should be ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19681


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150864|review?                     |review-
               Flag|                            |




--- Comment #31 from Julien Chaffraix <jchaffraix at webkit.org>  2012-07-17 10:57:49 PST ---
(From update of attachment 150864)
View in context: https://bugs.webkit.org/attachment.cgi?id=150864&action=review

AFAICT your change doesn't change anything in how the function behave, yet we pass your test. Is it possible that this got fixed in the meantime and that you only need to land your test case?

> Source/WebCore/html/HTMLTableElement.cpp:450
> +    if (m_borderColorAttr && m_borderColorAttr) {

This change doesn't do anything.

> Source/WebCore/html/HTMLTableElement.cpp:455
> +    if (m_borderAttr) {

Per the checks above, this should be an ASSERT as you cannot reach this point without having m_borderAttr be NULL.

> Source/WebCore/html/HTMLTableElement.cpp:460
> +
> +    return 0;

That case can't be reached as it would mean that !m_borderColorAttr && !m_borderAttr (which is checked above).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.