[Webkit-unassigned] [Bug 91506] Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 10:29:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91506





--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org>  2012-07-17 10:29:21 PST ---
(In reply to comment #0)
> Created an attachment (id=152770)
 --> (https://bugs.webkit.org/attachment.cgi?id=152770&action=review) [details]
> Page which I used to reproduce bug
> 
> In FontCacheWin.cpp, getLastResortFallbackFont(), currently line 340, I believe there is a typo that causes the return from getCachedFontData() to be ignored.  I'm a little surprised the compiler even allows this.  The problem is that the closing parenthesis is in the wrong place:

Wow, great catch!

The compiler is probably fine with it because getCachedFontData has optional parameters (arg!), and this then becomes a comma expression, really only intended for the initializer section for a for loop.  Like: "for (int i=0, j=0; ...)".
<http://publib.boulder.ibm.com/infocenter/comphelp/v8v101/index.jsp?topic=%2Fcom.ibm.xlcpp8a.doc%2Flanguage%2Fref%2Fco.htm>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list