[Webkit-unassigned] [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 06:57:22 PDT 2012


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #152744|review?                     |review-
               Flag|                            |

--- Comment #43 from Pavel Feldman <pfeldman at chromium.org>  2012-07-17 06:57:20 PST ---
(From update of attachment 152744)
View in context: https://bugs.webkit.org/attachment.cgi?id=152744&action=review

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:492
> +    , m_isPausedInDebugger(false)

Nit: we rarely use "is" prefix.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:501
> +        drawHighlight(context);

Nit: You could simply call drawHighlight here and bail out from there in case of no highlightData.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:541
> +void InspectorOverlay::setIsPausedInDebugger(bool flag)

setPausedInDebugger, sorry about that.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1038
> +    m_overlay->setHighlight(m_document.get(), m_highlightData.get());

m_document will expire upon reset.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1606
> +    m_overlay->getHighlight(m_highlightData->node ? m_highlightData->node->document() : m_document.get(), m_highlightData.get(), highlight);

I was hoping m_highlightData could go away from the DOMAgent.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list