[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #18 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-17 00:48:51 PST ---
(From update of attachment 152707)
View in context: https://bugs.webkit.org/attachment.cgi?id=152707&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:972
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(userAgent, false);

I prefer if we accept a NULL userAgent. WKPageSetCustomUserAgent() accepts a NULL user agent so I think we should allow it as well. We should simply document in the header that this resets to the default user agent.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:423
> +/**

Extra space before comment?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:427
> +* @param user_agent user agent, may be @c EINA_FALSE if user_agent is 0.

I think you mean "may return" not "may be ". Also please use "@c NULL" instead of 0. Finally, I would prefer if passing a NULL user agents resets the user agent string to the default one.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:433
> +/**

Extra space before comment?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.