[Webkit-unassigned] [Bug 90927] [EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90927





--- Comment #21 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-07-17 00:45:50 PST ---
(From update of attachment 152668)
View in context: https://bugs.webkit.org/attachment.cgi?id=152668&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:688
> + * The text which is used by WKPageSetPageFindClient was found.

Reports that the requested text was found.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:690
> + * Emits signal: "text,found" with count.

... with the number of matches.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:957
> +COMPILE_ASSERT_MATCHING_ENUM(EWK_FIND_OPTIONS_CASE_INSENSITIVE, kWKFindOptionsCaseInsensitive);

Please add short comment why those asserts are needed.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:48
> + * - "text,found", unsigned*: text was found by ewk_view_text_find with the number of matches.

what do you say about: the requested text was found and it gives the number of matches. ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:194
> + * @EWK_FIND_OPTIONS_NONE: no search flags, this means a case

I think those detailed descriptions should be moved next to their declarations as it has been done in wk1.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:208
> + * @info    Keep this in sync with WKFindOptions.h

This line should be moved below.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:209
> + * Enum values used to specify search options.

I'd add @brief tag here.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:433
> +* Queries to find text

Searches the given string in the document.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:438
> +* @param max_match_count max count to find, unlimited if 0

please remove max_match_count

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:440
> +* @return @c EINA_TRUE on successful request, @c EINA_FALSE on errors

What is returned if string wasn't found? :)

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:445
> +* Queries to clear highlight of searched text.

Clears the highlight ...

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:449
> +* @return @c EINA_TRUE on successful request, @c EINA_FALSE on errors

in wk1 we just use "@c EINA_TRUE on success"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.