[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #16 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-16 22:49:07 PST ---
(From update of attachment 152502)
View in context: https://bugs.webkit.org/attachment.cgi?id=152502&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:966
> +        eina_stringshare_replace(&priv->userAgent, toImpl(userAgentString.get())->string().utf8().data());

eina_stringshare_add() is sufficient.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:397
> +* Queries to set the user agent string.

"Queries to set" does not make much sense. "Sets the user agent string" maybe?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:400
> +*

Missing @param for user_agent. Please document what happens if user_agent is NULL.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:410
> +* @return @c user agent string

It should be documented that the user agent is stringshared. See ewk_intent.h documentation for examples.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.