[Webkit-unassigned] [Bug 90661] [Shadow] distribute nodes don't inherit styles from parentNodeForRenderingAndStyle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90661





--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-07-16 16:27:55 PST ---
(From update of attachment 151208)
View in context: https://bugs.webkit.org/attachment.cgi?id=151208&action=review

> Source/WebCore/ChangeLog:3
> +        [Shadow] distribute nodes don't inherit styles from parentNodeForRenderingAndStyle.

distribute -> Distributed

Perhaps a better title for this bug would be: Distributed nodes should not share styles

> Source/WebCore/css/StyleResolver.h:485
> +    bool m_elementDistributed;

Do we really need a member here? Can we not infer this information somehow from parentStyle? I am not sure, just asking.

Also -- if we do, the name needs to be more descriptive. It's hard to understand for someone who doesn't normally deal with Shadow DOM terminology. Can this be just a bit flag for disabling style sharing? Will this produce better code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.