[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151028|review?                     |review-
               Flag|                            |




--- Comment #54 from Geoffrey Garen <ggaren at apple.com>  2012-07-16 12:47:25 PST ---
(From update of attachment 151028)
View in context: https://bugs.webkit.org/attachment.cgi?id=151028&action=review

Overall approach in JSC looks good. One comment below.

> Source/JavaScriptCore/parser/Parser.cpp:1639
> +        expr = context.makePostfixNode(m_lexer->lastLineNumber(), tokenColumn(), expr, OpPlusPlus, subExprStart, lastTokenEnd(), tokenEnd());

It's awkward to get the line number from the lexer, but get the column number from the current token. Let's get all the data from the current token instead.

The smallest change you can make to fix this is to pass a reference to the current token instead of two separate numbers.

It would be even better to rename JSTokenInfo to TokenLocation, put line, column, start, end, and divot all in TokenLocation, and pass just that one object to all clients.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.