[Webkit-unassigned] [Bug 91354] Machine stack marker should not gather values already piled up on the stack before JSC working

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 16 11:41:39 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91354


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152470|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2012-07-16 11:41:38 PST ---
(From update of attachment 152470)
I don't think this change is valid.  The StackBounds will be captured on the first call into WebCore, when the thread data is initialized.  This may occur at a deep stack depth.  Subsequent calls into WebCore may occur at a much shallower stack depth.  It certainly is the case that there may be some range of the stack that we currently mark, which one could safely avoid marking – but I don't think this patch safely determines what that line is (also, I'm not sure how one would safely define this high water mark).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list