[Webkit-unassigned] [Bug 91143] [BlackBerry] Upstream WebGL Code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91143


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152538|review?                     |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-07-16 08:39:49 PST ---
(From update of attachment 152538)
View in context: https://bugs.webkit.org/attachment.cgi?id=152538&action=review

Still some things to cleanup.

> Source/WebCore/ChangeLog:3
> +        This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation.

This line should go below the Reviewed by line.

> Source/WebCore/ChangeLog:23
> +        * platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary  whitespace.

Remove unnecessary whitespace. <- there is unnecessary whitespace in that sentence.

> Source/WebKit/ChangeLog:3
> +        This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation.

This line should go below the Reviewed by line.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:142
> +#endif

Better add some whitespace in some of these lines.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:53
> +    // Currently only format=RGBA, type=UNSIGNED_BYTE is supported by the specification: http://www.khronos.org/reg

Huh? gives 404

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.