[Webkit-unassigned] [Bug 90927] [EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90927





--- Comment #17 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-16 03:36:47 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > (From update of attachment 152499 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=152499&action=review
> > 
> > >>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:954
> > >>> +
> > >> 
> > >> Please use COMPILE_ASSERT_MATCHING_ENUM() from ewk_private.h to make sure EwkFindOptions and WKFindOptions enumerations match.
> > > 
> > > Do you mean that make a new file(ewk_private.h) and defining the enums using COMPILE_ASSERT_MATCHING_ENUM?
> > 
> > I understand what you say by referring gtk port.
> > I'll make another patch for this. Do you agree with me?
> > 
> > I'll make ewk_private.h and define it.
> 
> ewk_private.h and the macro are already defined. You just need to use them :)

You can use ewk_navigation_policy_decision.cpp as example, it already uses the macro.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.