[Webkit-unassigned] [Bug 90927] [EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90927





--- Comment #13 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-16 02:27:09 PST ---
(From update of attachment 152499)
View in context: https://bugs.webkit.org/attachment.cgi?id=152499&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:954
> +

Please use COMPILE_ASSERT_MATCHING_ENUM() from ewk_private.h to make sure EwkFindOptions and WKFindOptions enumerations match.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:963
> +    WKPageFindString(toAPI(priv->pageClient->page()), findText.get(), options, maxMatchCount);

Here you will need to cast the EwkFindOptions into WKFindOptions.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:194
> +    EWK_FIND_OPTIONS_CASE_INSENSITIVE = 1 << 0,

Would be nice to have per-value documentation as some of them are not obvious. WebKitFindOptions has the documented, you can use it as reference.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:203
> +typedef uint32_t EwkFindOptions;

In other files we use:
typedef _EwkFindOptions EwkFindOptions;

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:420
> +* @param max_match_count max count to find

Does 0 mean unlimited? If so, it should be documented.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:424
> +EAPI Eina_Bool ewk_view_text_find(Evas_Object *o, const char *text, EwkFindOptions options, unsigned max_match_count);

Nice to introduce this API. However, this will highlight all the matches in the page. I think we need another API to unhighlight the search terms when the user closes the search UI. Basically, I think we need a wrapper around WKPageHideFindUI().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.