[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-16 01:51:45 PST ---
(From update of attachment 152497)
View in context: https://bugs.webkit.org/attachment.cgi?id=152497&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:952
> +    eina_stringshare_replace(&priv->userAgent, userAgent);

I think you need to set user agent when stringshare_replace is succeeded.

Please see also WK1 implementation.
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.cpp#L2044

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:966
> +        WKRetainPtr<WKStringRef> userAgentString(AdoptWK, WKPageCopyUserAgent(toAPI(priv->pageClient->page())));

By the way, is there default user agent ? IIRC, there is no default user agent if we don't set user agent. If this is true, we don't need to have this logic to get user agent.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:410
> +* @return @c user agent string

If my comment is correct, I think you need to update this comment as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.