[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-16 00:55:50 PST ---
(From update of attachment 152493)
View in context: https://bugs.webkit.org/attachment.cgi?id=152493&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:970
> +        OwnArrayPtr<char> buffer = adoptArrayPtr(new char[length]);

Should you use this ? Is below more simple ?

toImpl(userAgentString.get())->string().utf8().data();

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:403
> +EAPI Eina_Bool ewk_view_user_agent_set(Evas_Object* o, const char* user_agent);

Move '*' to variable side for public APIs.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:412
> +EAPI const char* ewk_view_user_agent_get(const Evas_Object* o);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.