[Webkit-unassigned] [Bug 90927] [EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 23:50:49 PDT 2012


--- Comment #8 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-15 23:50:48 PST ---
(From update of attachment 152484)
View in context: https://bugs.webkit.org/attachment.cgi?id=152484&action=review

Do we have an API to find text matches somewhere? If not, the client does not bring anything in terms of functionality, does it?

> Source/WebKit2/ChangeLog:2
> +        Reviewed by NOBODY (OOPS!).

Misunderstanding here :) The "Reviewed By" needs to be under the bug URL and before your changelog explanation.

> Source/WebKit2/ChangeLog:6
> +

Missing changelog explanation.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:685
> + * The text was changed.

This documentation seems very imprecise.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:44
> + * - "text,found", unsigned*: text was found.

You need to explain what the unsigned* argument is here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list