[Webkit-unassigned] [Bug 83045] Improve line breaking performance for complex text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83045





--- Comment #9 from nholbrook at apple.com  2012-07-15 23:50:43 PST ---
(In reply to comment #8)
> On further reflection, I think we should just put the TextLayout class in a header so we don’t need this function.

Unless I'm missing something, this is actually the cleanest approach without simply moving the problem elsewhere. Part of the problem stems from the class definition needing to be visible at the point of OwnPtr declaration: this means that any header TextLayout is in also needs to include ComplexTextController.h but of course that is meant to be a private implementation detail too.

> > Source/WebCore/platform/graphics/mac/ComplexTextController.h:171
> > +    Vector<unsigned, 16> m_runIndices;
> 
> Where did the number 16 come from? I guess the vectors above all say 64 with no comment saying where that came from.

It was just a seat of the pants number. Since it's meant to correlate to reasonable number of bidi runs in a layout anyway I've decreased it to 8 since in my tests it doesn't seem to make much difference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.