[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-14 04:51:37 PST ---
(From update of attachment 151199)
View in context: https://bugs.webkit.org/attachment.cgi?id=151199&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:34
> +    NotificationPresenterClientEfl(Evas_Object* view);

Use *explicit* keyword for constructor which has a parameter.

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:41
>> +#if ENABLE(LEGACY_NOTIFICATIONS)
> 
> I would really let EFL just not support legacy notifications. You are adding much code and it makes it even harder removing the feature later.

According to my quick search, it looks other ports are supporting LEGACY_NOTIFICATIONS. But, there is no reason to use LEGACY_NOTIFICATIONS on EFL port, I also think we don't need to support it.

> Source/WebKit/efl/ewk/ewk_view.cpp:4515
> +    EWK_VIEW_SD_GET(ewkView, smartData);

Use EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false) instead of this.

> Source/WebKit/efl/ewk/ewk_view.cpp:4516
> +    EWK_VIEW_PRIV_GET(smartData, priv);

Use EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.