[Webkit-unassigned] [Bug 91206] [EFL][WK2] Add ewk_setting.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91206





--- Comment #5 from EunMi Lee <eunmi15.lee at samsung.com>  2012-07-13 22:45:21 PST ---
(In reply to comment #4)
> (From update of attachment 152198 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152198&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_setting.cpp:29
> > +struct _Ewk_Setting {
> 
> I think it should be "Ewk_Settings" (plural).
> 
OK, I will change it to ewk_settings.

> > Source/WebKit2/UIProcess/API/efl/ewk_setting.cpp:36
> > +    setting->preferences = wkPreferences;
> 
> It would be nice if you could use a constructor like for the other Ewk classes.
> 

Thanks, I will use constructor.

> > Source/WebKit2/UIProcess/API/efl/ewk_setting.h:29
> > +
> 
> I think we should add a few important settings in this patch already. It looks bad to add an empty wrapper.
> 

Yes, so I will add a few settings APIs.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:265
> > +EAPI Ewk_Setting* ewk_view_setting_get(Evas_Object* o);
> 
> Stars are on the wrong side.

My mistake. I will fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.