[Webkit-unassigned] [Bug 87935] [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87935





--- Comment #18 from Seokju Kwon <seokju.kwon at samsung.com>  2012-07-13 22:22:32 PST ---
(In reply to comment #17)
> (From update of attachment 151398 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151398&action=review
> 
> >> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:773
> >> +        ecore_main_loop_begin();
> > 
> > I wonder if this is meaningful? Because ecore_main_loop_begin() is already called at the beginning of layout test.
> > 
> > http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L257
> 
> I'm not clear this yet. Does inspector call ecore_main_loop_begin() / _quit() first before calling it from runTest() of DumpRenderTree.cpp ? Could you explain the reason again ?
> 
It can't test the inspector without page(inspector.html) has finished loading on the view of inspector.
I think that it can't complete loading before it loads testURL on EFL Port. So it should wait until the page has finished loading with ecore_main_loop_begin() / _quit().

> In addition, I don't like to call ecore_main_loop_begin() / _quit() from different files. If you call this in LayoutTestControllerEfl.cpp, it is good to call ecore_main_loop_quit() in here as well. I think this is good to debug.

I agree with you. I will move it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.