[Webkit-unassigned] [Bug 91281] JSC: OfflineASM Pretty printing and commenting enhancements

Fri Jul 13 17:33:05 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=91281

--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2012-07-13 17:33:05 PST ---
(From update of attachment 152353)
View in context: https://bugs.webkit.org/attachment.cgi?id=152353&action=review

Looks good to me. I'd like Phil to take a look too, since he's more familiar with the Ruby driver. I've CC'd him.

One comment below.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:305
> +    loadp CodeBlock[cfr], t2                // t2<CodeBlock> = cfr.CodeBlock
> +    loadi CodeBlock::m_numVars[t2], t2      // t2<size_t> = t2<CodeBlock>.m_numVars

It looks like these comments parrot the LL assembly language in a slightly modified form. Perhaps comment dumping mode should just dump the LL assembly. I could see myself using that when I debugged something in the interpreter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.