[Webkit-unassigned] [Bug 90175] [BlackBerry] Implement GCActivityCallback with platform timer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 10:23:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90175


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152285|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-07-13 10:23:16 PST ---
(From update of attachment 152285)
View in context: https://bugs.webkit.org/attachment.cgi?id=152285&action=review

LGTM.

> Source/JavaScriptCore/heap/HeapTimer.h:70
> +    bool m_valid;

May be a bit strange to declare before the getter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list