[Webkit-unassigned] [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90880





--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2012-07-13 10:21:06 PST ---
(From update of attachment 152280)
View in context: https://bugs.webkit.org/attachment.cgi?id=152280&action=review

As we agreed offline, lets do the following:
1) Convert DOMNodeHighlighter into the InspectorOverlay class
2) Put its instance into the InspectorPageAgent and configure it from within InspectorDOMAgent and PageDebuggerAgent
3) Make sure that getHighlight is still available on this new overlay so that Timothy could access it and paint highlight on the embedder level.

Timothy, this should not change the way things work for you.

>> Source/WebCore/inspector/DOMNodeHighlighter.cpp:490
>> +InspectorDashBoard::InspectorDashBoard(InstrumentingAgents* instrumentingAgents, InspectorClient* client, InspectorPageAgent* pageAgent)
> 
> DashBoard is one word. So this should be InspectorDashboard. Though, I'm not sure this should even be a separate class. Also classes in WebCore get their own file.

You don't need instrumentingAgents here.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:206
> +    , m_dashBoard(InspectorDashBoard::create(instrumentingAgents, client, pageAgent))

Dashboard should not belong to DOMAgent.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1091
> +    if (InspectorInstrumentation::isDebuggerPaused(m_instrumentingAgents))

DOM agent should not be debugger-aware.

> Source/WebCore/inspector/InspectorInstrumentation.h:101
> +    static bool isDebuggerPaused(InstrumentingAgents*);

Why do you need this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.