[Webkit-unassigned] [Bug 90949] Optimizing blend filter to ARM-NEON with intrinsics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90949


Gabor Rapcsanyi <rgabor at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Gabor Rapcsanyi <rgabor at webkit.org>  2012-07-13 08:35:30 PST ---
(In reply to comment #4)
> (From update of attachment 152235 [details])
> r=me
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=152235&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        The feBlend SVG filter modes can be greatly fasten up with ARM-NEON since
> > +        we are able to calculate with 2 pixels (8 channels) at the same time.
> > +        The code is written with NEON intrinsics and it doesn't affect the
> > +        general - it has the same behaviour as the original algorithm.
> 
> Please mention the speedup.
> 
> > Source/WebCore/platform/graphics/filters/FEBlend.cpp:157
> > +    else { // if there is just one pixel
> 
> Please use full sentences for comments.

I corrected those, thanks for the review.
Patch landed: http://trac.webkit.org/changeset/122582

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.