[Webkit-unassigned] [Bug 91231] WebHistoryItem: Enable reading selected file names from document state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91231





--- Comment #3 from jochen at chromium.org  2012-07-13 06:49:53 PST ---
(From update of attachment 152246)
Can you add a test that this works? See tests/WebViewTest for how to easily create a HTMLDocument

Also, a ChangeLog is missing :)

View in context: https://bugs.webkit.org/attachment.cgi?id=152246&action=review

> Source/WebKit/chromium/public/WebDocumentState.h:39
> +    WebDocumentState(const WebVector<WebString>&);

explicit?

> Source/WebKit/chromium/public/WebHistoryItem.h:106
>      WEBKIT_EXPORT WebVector<WebString> documentState() const;

I'd group the new and old methods together and add a // FIXME: comment about removing the old ones and dropping the bool

> Source/WebKit/chromium/src/WebDocumentState.cpp:37
> +    : m_data(documentState)

the constructor and the data() accessor are so small, you could move them to the header

> Source/WebKit/chromium/src/WebHistoryItem.cpp:221
> +void WebHistoryItem::setDocumentState(const WebDocumentState& state)

can you implement the old setDocumentState / documentState by means of the new methods, so we don't have a copy of the code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.