[Webkit-unassigned] [Bug 91206] [EFL][WK2] Add ewk_setting.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91206





--- Comment #4 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-13 06:23:30 PST ---
(From update of attachment 152198)
View in context: https://bugs.webkit.org/attachment.cgi?id=152198&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_setting.cpp:29
> +struct _Ewk_Setting {

I think it should be "Ewk_Settings" (plural).

> Source/WebKit2/UIProcess/API/efl/ewk_setting.cpp:36
> +    setting->preferences = wkPreferences;

It would be nice if you could use a constructor like for the other Ewk classes.

> Source/WebKit2/UIProcess/API/efl/ewk_setting.h:29
> +

I think we should add a few important settings in this patch already. It looks bad to add an empty wrapper.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:265
> +EAPI Ewk_Setting* ewk_view_setting_get(Evas_Object* o);

Stars are on the wrong side.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.