[Webkit-unassigned] [Bug 89198] Web Inspector: too many hardcoded strings in InspectorBackendDispatcher.

Fri Jul 13 03:44:07 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=89198

Peter Rybin <prybin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150997|                            |review?, commit-queue?
               Flag|                            |

--- Comment #4 from Peter Rybin <prybin at chromium.org>  2012-07-13 03:44:06 PST ---
(From update of attachment 150997)
View in context: https://bugs.webkit.org/attachment.cgi?id=150997&action=review

>> Source/WebCore/inspector/CodeGeneratorInspector.py:1981
>> +        size_t length = ARRAY_SIZE(commandNames);
> 
> It should be WTF_ARRAY_LENGTH(commandNames), not sure why compiler didn't complain about it. Is ARRAY_SIZE defined somewhere in WebKit, I only see 2 places (http://code.google.com/p/chromium/source/search?q=define%5CsARRAY_SIZE+file%3AWebKit&origq=define%5CsARRAY_SIZE+file%3AWebKit&btnG=Search+Trunk), none of which should be visible here?

Actually I made my own -- didn't know the right name for search. Replaced.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.