[Webkit-unassigned] [Bug 90277] Web Inspector: added Paint events for Images to TimelineAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 03:16:36 PDT 2012


--- Comment #37 from Pavel Feldman <pfeldman at chromium.org>  2012-07-13 03:16:34 PST ---
(From update of attachment 151904)
View in context: https://bugs.webkit.org/attachment.cgi?id=151904&action=review

>>> Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:86
>>> +        InspectorInstrumentation::willDecodeImage("BMP");
>> I can see existing TRACE_EVENT called from within decode. Is there a reason we want to put our instrumentation elsewhere? Also, could use introduce RAII concept (InspectorInstrumentation::TraceEvent("ImageDecode") trace;) for this kind of instrumentation?
> We'd like to only show full image decodes, as opposed to size only, as the latter are presumed to be cheap -- hence the instrumentation is at the (only) call site that requests full decode. This may be moved instead to the location of TRACE, but will have an extra conditional -- do you prefer this?

I think you should cut it on the agent level (do not send to the front-end pure header decodes).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list