[Webkit-unassigned] [Bug 90927] [EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90927





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-12 22:26:07 PST ---
(From update of attachment 152115)
View in context: https://bugs.webkit.org/attachment.cgi?id=152115&action=review

I don't see the point of this patch if you don't define any callback. In itself, this patch provides no additional functionality, it is just more code to maintain for no good reason.

> Source/WebKit2/ChangeLog:3
> +        Need a short description and bug URL (OOPS!)

Please remove this line.

> Source/WebKit2/ChangeLog:4
> +

Ditto.

> Source/WebKit2/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

The "Reviewed by" line is supposed to be above your changelog text, not under.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.