[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 20:57:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=40300





--- Comment #66 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-12 20:57:20 PST ---
(In reply to comment #65)
> (In reply to comment #64)
> > (In reply to comment #63)
> > > (In reply to comment #62)
> > > > (In reply to comment #61)
> > > > > (In reply to comment #58)
> > > > > > (In reply to comment #56)
> > > > > > > (From update of attachment 151849 [details] [details] [details] [details] [details] [details] [details])
> > > > > > > View in context: https://bugs.webkit.org/attachment.cgi?id=151849&action=review
> > > > > > > 
> > > > > > > > Source/JavaScriptCore/interpreter/Interpreter.cpp:1094

> > (3) Move compiling related code to an independent function compile(), and let execute() to invoke it.    
> 
> That's what I'm asking for.
> 
> > I said the reason why I don't choose (1). I prefer (2) because it brings minimal modification. Do you mean you prefer (3)? I just concern there is too big modification.
> 
> (3) is the only sensible path.

Ok, I understand what you mean now. I'll try to make a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list