[Webkit-unassigned] [Bug 90963] [User Timing] Implementation of User Timing W/O Getter Method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90963





--- Comment #13 from pdeng6 <pan.deng at intel.com>  2012-07-12 20:49:50 PST ---
(In reply to comment #9)
> (In reply to comment #3)
> > (From update of attachment 151683 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=151683&action=review
> > 
> > Can you also add FIXMEs to the Performance Timeline functions indicating that they need to return User Timing too? You can fix them in a separate bug and patch.
> > 
> > >> Source/WebCore/ChangeLog:9
> > >> +        No new tests, feature is not enabled in any platform currently.
> > > 
> > > You should still commit tests for these, but just skip them on all platforms.
> > 
> > I think the actual reason is that there's no way to observe it working. We haven't hooked it up to getEntries() yet. You can call the functions, but won't be able to see if they're doing the right things. I think we can hold off on tests until we have observable behavior.
> 
> I see. I'd rather we do this in the opposite order if possible, e.g. hook something up to getEntries first.

(In reply to comment #9)
> (In reply to comment #3)
> > (From update of attachment 151683 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=151683&action=review
> > 
> > Can you also add FIXMEs to the Performance Timeline functions indicating that they need to return User Timing too? You can fix them in a separate bug and patch.
> > 
> > >> Source/WebCore/ChangeLog:9
> > >> +        No new tests, feature is not enabled in any platform currently.
> > > 
> > > You should still commit tests for these, but just skip them on all platforms.
> > 
> > I think the actual reason is that there's no way to observe it working. We haven't hooked it up to getEntries() yet. You can call the functions, but won't be able to see if they're doing the right things. I think we can hold off on tests until we have observable behavior.
> 
> I see. I'd rather we do this in the opposite order if possible, e.g. hook something up to getEntries first.

Thanks.
I have test case locally, however, to have a consistent style of w3c and James's test harness, I think it would be better to submit in another patch for https://bugs.webkit.org/show_bug.cgi?id=91072, and it need some more work.
so, could you please have a review this patch ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.