[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40300





--- Comment #58 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-12 19:34:09 PST ---
(In reply to comment #56)
> (From update of attachment 151849 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151849&action=review
> 
> > Source/JavaScriptCore/interpreter/Interpreter.cpp:1094
> > -JSValue Interpreter::execute(ProgramExecutable* program, CallFrame* callFrame, ScopeChainNode* scopeChain, JSObject* thisObj)
> > +JSValue Interpreter::execute(ProgramExecutable* program, CallFrame* callFrame, ScopeChainNode* scopeChain, JSObject* thisObj, bool compileOnly)
> 
> It would be better if we created a compile() helper, preferably outside of the Interpreter class if it's easy.  That way instead of saying execute(blah, true) you'd say compile().

I considered this way once. But Interpreter::execute implements all steps of compiling, so that if I want to write an independent compile(), I just need to copy Interpreter::execute and delete several lines, it looks ugly.
It's the reason.  

> 
> > Source/JavaScriptCore/runtime/Completion.cpp:-56
> > -    JSLockHolder lock(exec);
> 
> Did you put in some locking elsewhere to justify the removal of this lock acquisition?

Oops, sorry. It's supposed to be here. It's a mistake, seems imported from attachment 149263. I'll correct it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.