[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 14:49:07 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=40300





--- Comment #56 from Filip Pizlo <fpizlo at apple.com>  2012-07-12 14:49:05 PST ---
(From update of attachment 151849)
View in context: https://bugs.webkit.org/attachment.cgi?id=151849&action=review

> Source/JavaScriptCore/interpreter/Interpreter.cpp:1094
> -JSValue Interpreter::execute(ProgramExecutable* program, CallFrame* callFrame, ScopeChainNode* scopeChain, JSObject* thisObj)
> +JSValue Interpreter::execute(ProgramExecutable* program, CallFrame* callFrame, ScopeChainNode* scopeChain, JSObject* thisObj, bool compileOnly)

It would be better if we created a compile() helper, preferably outside of the Interpreter class if it's easy.  That way instead of saying execute(blah, true) you'd say compile().

> Source/JavaScriptCore/runtime/Completion.cpp:-56
> -    JSLockHolder lock(exec);

Did you put in some locking elsewhere to justify the removal of this lock acquisition?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list