[Webkit-unassigned] [Bug 91148] New: [V8] Replaceable WebIDL attributes are broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91148

           Summary: [V8] Replaceable WebIDL attributes are broken
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
               URL: http://www.w3.org/TR/WebIDL/#Replaceable
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: arv at chromium.org
                CC: abarth at webkit.org, atwilson at chromium.org,
                    japhet at chromium.org, antonm at chromium.org,
                    haraken at chromium.org
        Depends on: 49739


DOMWindow.idl has a bunch of [Replaceable] attributes. This means that the js property should be writable and setting the property should just replace the property.

The following shouldBe* both fails.

window.innerHeight = 42;
shouldBe('window.innerHeight', '42');
shouldBeTrue('Object.getOwnPropertyDescriptor(window, "innerHeight").writable)');

Once we implement bug 49739 the setter needs to defineProperty on the this object. Something like

{
  get: function() {
    return impl->innerHeight()
  },
  set: function(v) {
    Object.defineProperty({
      value: v,
      writable: true
      ...
  }
  ...
}

Right now we only have a get interceptor. I think we can get by using a set interceptor that calls ForceSet but it is possible that we also have to Delete the old property.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.