[Webkit-unassigned] [Bug 91130] [chromium] Fix initialization race to determine the initial memory limit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91130





--- Comment #3 from Eric Penner <epenner at chromium.org>  2012-07-12 12:16:33 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > In LayerRendererChromium, we set the memory limit via a callback:
> > 
> >     if (m_capabilities.usingGpuMemoryManager)
> >         m_context->setMemoryAllocationChangedCallbackCHROMIUM(this);
> >     else
> >         m_context->m_client->setMemoryAllocationLimitBytes(some_default);
> > 
> > However, this leaves us with the question of what to do before we get the callback should we:
> > - Wait for the callback before rendering anything?
> > - Keep using a default a like we do currently?
> > - Use a synchronous call to get the limit rather than a callback? It could decide whether to block etc. or just return the default itself?
> How is this functionally different from option 1?  The time to get an allocation is the same in both case, right?  Does initializing to 0 memory allocation somehow show us down?

Just thinking out loud. It could hide the implementation and decision of whether to block and/or what default to give? Although the async way is likely preferred if we do always want to wait for a non-zero allocation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.