[Webkit-unassigned] [Bug 89000] [CSS Regions] Fix the lifecycle for the flow objects and their renderers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89000


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151916|review?                     |review+
               Flag|                            |




--- Comment #43 from Eric Seidel <eric at webkit.org>  2012-07-12 10:34:35 PST ---
(From update of attachment 151916)
View in context: https://bugs.webkit.org/attachment.cgi?id=151916&action=review

LGTM.

> Source/WebCore/dom/WebKitNamedFlowCollection.cpp:68
> +    RefPtr<WebKitNamedFlow> newFlow = WebKitNamedFlow::create(this, flowName);
> +    m_namedFlows.add(newFlow.get());
> +
> +    return newFlow.release();

Some of the WTF add functions return what they've added.  It's possible you could make these 3 into one line if that's true.

> Source/WebCore/rendering/RenderNamedFlowThread.h:83
> +    bool canBeDestroyed() const { return m_regionList.isEmpty() && m_contentNodes.isEmpty(); }

Is this virtual?  Or specific to RenderNamedFlowThread?  What about when the whole RenderView tree goes down?  Will things correctly get cleaned up then?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.