[Webkit-unassigned] [Bug 90277] Web Inspector: added Paint events for Images to TimelineAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90277


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151904|review?                     |review-
               Flag|                            |




--- Comment #35 from Pavel Feldman <pfeldman at chromium.org>  2012-07-12 06:33:41 PST ---
(From update of attachment 151904)
View in context: https://bugs.webkit.org/attachment.cgi?id=151904&action=review

> Source/WebCore/ChangeLog:8
> +        * English.lproj/localizedStrings.js:

Please explain what has changed and why.

> Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:86
> +        InspectorInstrumentation::willDecodeImage("BMP");

I can see existing TRACE_EVENT called from within decode. Is there a reason we want to put our instrumentation elsewhere? Also, could use introduce RAII concept (InspectorInstrumentation::TraceEvent("ImageDecode") trace;) for this kind of instrumentation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.