[Webkit-unassigned] [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90880





--- Comment #11 from Andrey Kosyakov <caseq at chromium.org>  2012-07-12 05:44:22 PST ---
(From update of attachment 151920)
View in context: https://bugs.webkit.org/attachment.cgi?id=151920&action=review

Can we disable dashboard when "inspect element" mode is on?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:372
> +class DevToolsDashBoard : public WebPageOverlay {

Can you please move it to a file of its own?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:443
> +            DEFINE_STATIC_LOCAL(RefPtr<Image>, buttonImageDefault, (Image::loadPlatformResource("mediaplayerPlayDisabled")));
> +            DEFINE_STATIC_LOCAL(RefPtr<Image>, buttonImage, (Image::loadPlatformResource("mediaplayerPlay")));
> +            DEFINE_STATIC_LOCAL(RefPtr<Image>, buttonImageDown, (Image::loadPlatformResource("mediaplayerPlayDown")));
> +            DEFINE_STATIC_LOCAL(RefPtr<Image>, buttonImageHover, (Image::loadPlatformResource("mediaplayerPlayHover")));

I think we could pass resource ids from the outside, so we can reuse the class for other buttons. I think you can just pass the root name (e.g. "mediaplayerPlay") and derive the rest by adding specific states (Disabled/Play/Down/etc)

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:459
> +        void getState(bool& isFocused, bool& isPressed)

does this have to be public?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:465
> +        void updateState(bool isFocused, bool isPressed)

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.