[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #18 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-12 03:49:51 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > Created an attachment (id=151877)
 --> (https://bugs.webkit.org/attachment.cgi?id=151877&action=review) [details] [details]
> > Patch
> 
> Thanks for changes. Looks fine for me. 
> I'd add notes to ChangeLog that you are moving initialization of strings for protocol and host to the *_new method. That change allows to add const modifier for getters methods. Additionally null checks are added to the getters.

After updating ChangeLog according to Grezegorz's suggestion, I will give LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.