[Webkit-unassigned] [Bug 89186] [EFL][WK2] Add APIs to create, delete and get ewk_context.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89186





--- Comment #10 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-12 01:04:54 PST ---
(From update of attachment 149910)
View in context: https://bugs.webkit.org/attachment.cgi?id=149910&action=review

This patch probably needs updating because the Ewk Context now contains the BatteryProvider.

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:35
> +    _Ewk_Context(WKRetainPtr<WKContextRef> contextRef)

Why this change?

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:54
> +    return new Ewk_Context(adoptWK(WKContextCreate()));

return new Ewk_Context(WKContextCreate()); ?

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:65
> +Eina_Bool ewk_context_free(Ewk_Context* ewkContext)

Our *_free() functions usually don't return a boolean I believe.

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:69
> +    if (toImpl(ewkContext->context.get())->refCount() > 1)

This check does not look right. You need to free the ewkContext no matter what, the WKContext ref count does not matter here.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:524
> +    return priv->context;

Blank line before return?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.