[Webkit-unassigned] [Bug 89000] [CSS Regions] Fix the lifecycle for the flow objects and their renderers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 17:03:15 PDT 2012


--- Comment #40 from Andrei Bucur <abucur at adobe.com>  2012-07-11 17:03:14 PST ---
(In reply to comment #38)
> (From update of attachment 151436 [details])
> I've read this another 3 times through. :)  I think I finally understand what you're going for here.  Please answer my above questions and upload a new copy.  I think this needs one more round.
> Part of me would rather you did this in smaller pieces.  Like, for example, the item() and length() stuff doesn't need to be added until it's tested/used/exposed to the web.
I'll remove them.
> None of these weak pointers are actually necessary, since the AtomicString representing the name of the flow is sufficient to look up any flow or flow renderer.  But the pointers may be easier to use in the end, unsure.
I don't understand what you're trying to suggest :(.
> The test changes are not at all clear to me.  Are those just changes to the tests themselves?  Or is there a behavior change hidden in here?  Could we do the test chagnes separately?  Could we do whatever the behavior change is here in the smallest patch possible?
The tests need to be modified to take into account that getFlowByName can return null. This was not possible before the patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list