[Webkit-unassigned] [Bug 89000] [CSS Regions] Fix the lifecycle for the flow objects and their renderers

Wed Jul 11 16:32:32 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=89000

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151436|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #38 from Eric Seidel <eric at webkit.org>  2012-07-11 16:32:31 PST ---
(From update of attachment 151436)
I've read this another 3 times through. :)  I think I finally understand what you're going for here.  Please answer my above questions and upload a new copy.  I think this needs one more round.

Part of me would rather you did this in smaller pieces.  Like, for example, the item() and length() stuff doesn't need to be added until it's tested/used/exposed to the web.

None of these weak pointers are actually necessary, since the AtomicString representing the name of the flow is sufficient to look up any flow or flow renderer.  But the pointers may be easier to use in the end, unsure.

The test changes are not at all clear to me.  Are those just changes to the tests themselves?  Or is there a behavior change hidden in here?  Could we do the test chagnes separately?  Could we do whatever the behavior change is here in the smallest patch possible?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.