[Webkit-unassigned] [Bug 91028] New: MockFileSystem shouldn't create directories automatically in write_binary_file()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 15:29:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91028

           Summary: MockFileSystem shouldn't create directories
                    automatically in write_binary_file()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: eric at webkit.org, tony at chromium.org, abarth at webkit.org,
                    ojan at chromium.org


the MockFileSystem's implementation of write_binary_file() will "create" the directory for the file automatically; this is bad because it is inconsistent with what the real filesystem does and can mask bugs (e.g., bug 90872).

this was originally done for convenience so that you could just say mock_fs.write_text_file('foo/bar/baz.html') when writing your test and not have to worry about creating fake directories. However, we should probably a different way of doing this that doesn't break the semantics for non-test code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list