[Webkit-unassigned] [Bug 90911] [BlackBerry] Implement Date/Time picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90911


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151739|review?                     |review-
               Flag|                            |




--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-07-11 11:52:22 PST ---
(From update of attachment 151739)
View in context: https://bugs.webkit.org/attachment.cgi?id=151739&action=review

Looks good, found some small stuff.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:22
> +#include "IntSize.h"

You can use forward reference.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:25
> +#include "WebString.h"

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:55
> +    HTMLInputElement* m_element;

Can you recheck the private situation again? I think at least the member vars can be made private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.