[Webkit-unassigned] [Bug 88070] [Gtk] Process Gtk 3.4 smooth scroll events properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88070


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151697|review?                     |review-
               Flag|                            |




--- Comment #17 from Martin Robinson <mrobinson at webkit.org>  2012-07-11 11:04:31 PST ---
(From update of attachment 151697)
View in context: https://bugs.webkit.org/attachment.cgi?id=151697&action=review

This patch looks fine for the most part to me, but it looks like it breaks the mac build.

> Tools/DumpRenderTree/gtk/EventSender.cpp:493
> +    bool paged = false;
> +    if (argumentCount >= 3) {
> +        paged = JSValueToBoolean(context, arguments[2]);

You don't usage paged outside of this scope so you should declare it in the inner scope.

> Tools/DumpRenderTree/gtk/EventSender.cpp:496
> +
> +        // Gtk+ does not support paged scroll events
> +        g_return_val_if_fail(!paged, JSValueMakeUndefined(context));

This whole thing can just be:

// We do not support paged scrolls yet.
g_return_val_if_fail(argumentCount < 3 || !JSValueToBoolean(context, arguments[2]), JSValueMakeUndefined(context));

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:402
> +    // not implemented

Should probably read 

// FIXME: Implement this.

as with other files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.