[Webkit-unassigned] [Bug 85856] [Chromium] Cannot show the left side of an RTL element with a vertical scrollbar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85856


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151640|review?                     |review+
               Flag|                            |




--- Comment #29 from Tony Chang <tony at chromium.org>  2012-07-11 10:26:25 PST ---
(From update of attachment 151640)
View in context: https://bugs.webkit.org/attachment.cgi?id=151640&action=review

Thanks for finding the spec for this.  Since IE is the only one with a different behavior and since having clientLeft be to the right of the scrollbar makes more sense, this looks correct to me.

Can you add some explicit tests for clientLeft (could be a separate patch)?

> LayoutTests/scrollbars/rtl/div-horizontal.html:36
> +var scrollbarWidthRTL = outerRTL.clientLeft > 0 ? outerRTL.clientLeft : outerRTL.offsetWidth - outerRTL.clientWidth;

Why do we need the outerRTL.clientLeft > 0 check? Won't outerRTL.offsetWidth - outerRTL.clientWidth always give the width of the scrollbar?

> LayoutTests/scrollbars/rtl/div-vertical.html:36
> +var scrollbarWidthRTL = outerRTL.clientLeft > 0 ? outerRTL.clientLeft : outerRTL.offsetWidth - outerRTL.clientWidth;

Same question about the clientLeft check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.