[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #6 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-11 04:21:21 PST ---
(In reply to comment #5)
> (From update of attachment 151652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review
> 
> >>> Source/WebKit/efl/ewk/ewk_security_origin.cpp:139
> >>> +    origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data());
> >> 
> >> I wonder if coreOrigin always has protocol.
> > 
> > If there is not protocol or host in coreOrigin, eina_stringshare_add returns NULL.
> 
> If so, don't you need to mention it in API description ? I think you need to mention this to ewk_security_origin.h.

There is no description about this, because this is a private function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.