[Webkit-unassigned] [Bug 80794] :first-line pseudo selector ignoring words created from :before

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80794





--- Comment #5 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-07-11 03:13:51 PST ---
(In reply to comment #3)
> (From update of attachment 147269 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147269&action=review
> 
> > Source/WebCore/rendering/RenderObject.cpp:2511
> > +    } else if (renderer->isBeforeOrAfterContent() && renderer->parent()->isBlockFlow()) {
> > +        // For handling content generated from :before/:after pseudo-element.
> > +        if (RenderBlock* firstLineBlock = renderer->parent()->firstLineBlock())
> > +            style = firstLineBlock->getCachedPseudoStyle(FIRST_LINE, style);
> 
> Don't you have to patch RenderObject::uncachedFirstLineStyle() too?
Agree! I missed out on that. Have uploaded another patch with the necessary changes.
Thanks for the review Robert. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.