[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 02:23:30 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #3 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-11 02:23:28 PST ---
(In reply to comment #2)
> (From update of attachment 151652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review
> 
> > Source/WebKit/efl/ewk/ewk_security_origin.cpp:139
> > +    origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data());
> 
> I wonder if coreOrigin always has protocol.
> 
> > Source/WebKit/efl/ewk/ewk_security_origin.cpp:140
> > +    origin->host = eina_stringshare_add(coreOrigin->host().utf8().data());
> 
> ditto.

If there is not protocol or host in coreOrigin, eina_stringshare_add returns NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list